Re: [Xen-devel] [PATCH v2] QEMU/helper2.c: Fix multiply issue for int and uint types

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 24 Aug 2012, Xu, Dongxiao wrote:
> > -----Original Message-----
> > > >From d71f9be82ec0079aa88f779dea90e475b177e32f Mon Sep 17 00:00:00
> > > >2001
> > > From: Dongxiao Xu <dongxiao.xu@xxxxxxxxx>
> > > Date: Mon, 20 Aug 2012 16:45:04 +0800
> > > Subject: [PATCH] helper2: fix multiply issue for int and uint types
> > >
> > > If the two multiply operands are int and uint types separately, the
> > > int type will be transformed to uint firstly, which is not the intent
> > > in our code piece. The fix is to add (int64_t) transform for the uint
> > > type before the multiply.
> > >
> > > This helps to fix the Xen hypevisor slow booting issue (boots more
> > > than 30 minutes) on another Xen hypervisor (the nested virtualization
> > > case).
> > >
> > > Signed-off-by: Dongxiao Xu <dongxiao.xu@xxxxxxxxx>
> > 
> > Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> Will this patch supposed to be merge in Xen 4.2?
> 
> Actually this is a fix for the nested Xen booting up issue, and it is already 
> merged in QEMU upstream.
> 
> We have several patches to fix issues and enable the nested virtualization 
> for Xen on Xen.
> They are:
> 
> 1) QEMU/helper2.c: Fix multiply issue for int and uint types.
> This patch is to fix the issue of nested Xen boot up. (in this mail)
> 
> 2) Xiantao Zhang will (suppose today) send out another patch to fix the L2 
> guest booting issue.
> 
> 3) nvmx: fix resource relinquish for nested VMX.
> This patch is to fix the destroy issue (resource is not released, xl list 
> still shows the guest) for L1 guest with a L2 guest running in it. (Already 
> sent into mailing list)
> 
> 4) Another patch is already merged by Ian J, which could fix the booting slow 
> issue for L2 guest, see:
> http://xenbits.xen.org/gitweb/?p=qemu-xen-unstable.git;a=commit;h=effd5676225761abdab90becac519716515c3be4
> 
> For the remaining three, will you accept them for Xen 4.2 release?

I can only speak for qemu-upstream-unstable, but I'll certainly backport
the int/uint fix as soon as it gets accepted in QEMU upstream.

Regarding the other patches, if any of them are for
qemu-upstream-unstable, I am going to backport them only if they are
bugfixes.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel