Re: [Xen-devel] [TESTDAY] xl cpupool-create segfaults if given invalid configuration

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-08-23 at 19:15 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [TESTDAY] xl cpupool-create segfaults 
> if given invalid configuration"):
> > This stuff is more of an Ian J thing but I wonder if when we hit the
> > syntax error that $$ still refers to the last value parsed, which we
> > think we are finished with but actually aren't? i.e. we've already
> > stashed it in the cfg and the reference in $$ is now "stale".
> 
> I will look at this tomorrow, but:
> 
> > (aside; I had to find and install the Lenny version of bison to make the
> > autogen diff readable. We should bump this to at least Squeeze in 4.3. I
> > also trimmed the diff to the generated files to just the relevant
> > looking bit -- in particular I trimmed a lot of stuff which appeared to
> > be semi-automated modifications touching the generated files, e.g. the
> > addition of emacs blocks and removal of page breaks ^L)
> 
> Perhaps we should do this now.  I don't think there's any reason to
> fear the squeeze version of bison.

I'd be happy with that.

When regenerating with Lenny's bison I got the following spurious
changes, no doubt due to some automated tree wide cleanup, which would
be nice to dispose of too.

diff -r af7143d97fa2 tools/libxl/libxlu_cfg_y.c
--- a/tools/libxl/libxlu_cfg_y.c        Tue Aug 14 15:59:38 2012 +0100
+++ b/tools/libxl/libxlu_cfg_y.c        Fri Aug 24 10:07:28 2012 +0100
@@ -819,7 +819,7 @@ int yydebug;
 # define YYMAXDEPTH 10000
 #endif
 
-
+
 
 #if YYERROR_VERBOSE
 
@@ -1030,7 +1030,7 @@ yysyntax_error (char *yyresult, int yyst
     }
 }
 #endif /* YYERROR_VERBOSE */
-
+
 
 /*-----------------------------------------------.
 | Release the memory associated to this symbol.  |
@@ -1101,7 +1101,7 @@ yydestruct (yymsg, yytype, yyvaluep, yyl
        break;
     }
 }
-
+
 
 /* Prevent warnings from -Wmissing-prototypes.  */
 
@@ -1689,11 +1689,3 @@ yyreturn:
 
 
 
-
-/*
- * Local variables:
- * mode: C
- * c-basic-offset: 4
- * indent-tabs-mode: nil
- * End:
- */
diff -r af7143d97fa2 tools/libxl/libxlu_cfg_y.h
--- a/tools/libxl/libxlu_cfg_y.h        Tue Aug 14 15:59:38 2012 +0100
+++ b/tools/libxl/libxlu_cfg_y.h        Fri Aug 24 10:07:28 2012 +0100
@@ -85,11 +85,3 @@ typedef struct YYLTYPE
 #endif
 
 
-
-/*
- * Local variables:
- * mode: C
- * c-basic-offset: 4
- * indent-tabs-mode: nil
- * End:
- */



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel