Re: [Xen-devel] [PATCH] xl: make "xl list -l" proper JSON

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH] xl: make "xl list -l" proper JSON"):
> xl: make "xl list -l" proper JSON

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Although ...

> +    yajl_gen_status s;
...
> +    if (default_output_format == OUTPUT_FORMAT_JSON) {
...
> +        s = yajl_gen_array_open(hand);
> +        if (s != yajl_gen_status_ok)
> +            goto out;
> +    } else
> +        s = yajl_gen_status_ok;

... I found that bit rather confusing (the handling of s) and had to
go and double-check the context.  It looks right though.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel