Re: [Xen-devel] [PATCH] libxl/qemu-xen: use cache=writeback for IDE and cache=none for SCSI

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 14 Aug 2012, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

ping

> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 0c0084f..1c94e80 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -549,10 +549,10 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>              if (disks[i].is_cdrom) {
>                  if (disks[i].format == LIBXL_DISK_FORMAT_EMPTY)
>                      drive = libxl__sprintf
> -                        (gc, "if=ide,index=%d,media=cdrom", disk);
> +                        (gc, "if=ide,index=%d,media=cdrom,cache=writeback", 
> disk);
>                  else
>                      drive = libxl__sprintf
> -                        (gc, "file=%s,if=ide,index=%d,media=cdrom,format=%s",
> +                        (gc, 
> "file=%s,if=ide,index=%d,media=cdrom,format=%s,cache=writeback",
>                           disks[i].pdev_path, disk, format);
>              } else {
>                  if (disks[i].format == LIBXL_DISK_FORMAT_EMPTY) {
> @@ -575,11 +575,11 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>                   */
>                  if (strncmp(disks[i].vdev, "sd", 2) == 0)
>                      drive = libxl__sprintf
> -                        (gc, "file=%s,if=scsi,bus=0,unit=%d,format=%s",
> +                        (gc, 
> "file=%s,if=scsi,bus=0,unit=%d,format=%s,cache=none",
>                           disks[i].pdev_path, disk, format);
>                  else if (disk < 4)
>                      drive = libxl__sprintf
> -                        (gc, "file=%s,if=ide,index=%d,media=disk,format=%s",
> +                        (gc, 
> "file=%s,if=ide,index=%d,media=disk,format=%s,cache=writeback",
>                           disks[i].pdev_path, disk, format);
>                  else
>                      continue; /* Do not emulate this disk */
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel