Re: [Xen-devel] [PATCH 4/5] cleanup error.h, included qapi-types.h aready has stdbool.h

[Luiz Capitulino <lcapitulino@xxxxxxxxxx>]

On Mon, 20 Aug 2012 01:39:38 +0200
Igor Mammedov <imammedo@xxxxxxxxxx> wrote:

> Signed-off-by: Igor Mammedov <imammedo@xxxxxxxxxx>
> ---
>  error.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/error.h b/error.h
> index 96fc203..643a372 100644
> --- a/error.h
> +++ b/error.h
> @@ -14,7 +14,6 @@
>  
>  #include "compiler.h"
>  #include "qapi-types.h"
> -#include <stdbool.h>

Hmm, not good. qapi-types.h includes <stdbool.h> for internal matters, files
including qapi-types.h shouldn't rely on this (as they can break if qapi-types.h
is changed not to include <stdbool.h>).

You can keep this code as it is.

>  
>  /**
>   * A class representing internal errors within QEMU.  An error has a 
> ErrorClass


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel