Re: [Xen-devel] [RFC PATCH 7/8]: PVH: grant changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> > > HYPERVISOR_memory_op(XENMEM_add_to_physmap, &xatp); if (rc != 0) {
> > >                           printk(KERN_WARNING
> > > @@ -1053,7 +1058,7 @@ static void gnttab_request_version(void)
> > >   int rc;
> > >   struct gnttab_set_version gsv;
> > >  
> > > - if (xen_hvm_domain())
> > > + if (xen_hvm_domain() || xen_pvh_domain())
> > 
> > Does something stop pvh using v2?
> 
> I had some issue related to grstatus field that was added, so punted it
> for now. It's phase II which is a big phase now :) :)...

It seems like it's got a lot of most independent bits in it, so
hopefully you should get some help ;-)

> > >  
> > > - if (xen_pv_domain())
> > > + /* PVH note: xen will free existing kmalloc'd mfn in
> > > +  * XENMEM_add_to_physmap */
> > > + if (xen_pvh_domain() && !gnttab_shared.addr) {
> > > +         gnttab_shared.addr =
> > > +                 kmalloc(max_nr_gframes * PAGE_SIZE,
> > > GFP_KERNEL);
> > > +         if ( !gnttab_shared.addr ) {
> > > +                 printk(KERN_WARNING "%s", kmsg);
> > 
> > Why this construct instead of just the string literal?
>  
> To keep line overflow. I dont' like code spanning 80 columns. If you split,
> then you can't grep.

FWIW CodingStyle relaxes the 80 column limit for literal strings for
exactly this reason.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel