Re: [Xen-devel] [PATCH 4/6] xen/mmu: Fix compile warnings.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-08-16 at 17:12 +0100, Konrad Rzeszutek Wilk wrote:
> linux/arch/x86/xen/mmu.c:1788:14: warning: comparison between pointer and 
> integer [enabled by default]
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  arch/x86/xen/mmu.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 90d31a2..4911354 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -1786,11 +1786,11 @@ void __init xen_setup_machphys_mapping(void)
>  {
>       struct xen_machphys_mapping mapping;
>  
> -     if (HYPERVISOR_memory_op(XENMEM_machphys_mapping, &mapping) == 0) {
> +     if (HYPERVISOR_memory_op(XENMEM_machphys_mapping, (void *)&mapping) == 
> 0) {

This changes seems to be unnecessary and not related to the commit
message.

>               machine_to_phys_mapping = (unsigned long *)mapping.v_start;
>               machine_to_phys_nr = mapping.max_mfn + 1;
>       } else {
> -             machine_to_phys_nr = MACH2PHYS_NR_ENTRIES;
> +             machine_to_phys_nr = (unsigned long)MACH2PHYS_NR_ENTRIES;

I must be missing something. Given:
        #define MACH2PHYS_VIRT_START  mk_unsigned_long(__MACH2PHYS_VIRT_START)
        #define MACH2PHYS_VIRT_END    mk_unsigned_long(__MACH2PHYS_VIRT_END)
        #define MACH2PHYS_NR_ENTRIES  
((MACH2PHYS_VIRT_END-MACH2PHYS_VIRT_START)>>__MACH2PHYS_SHIFT)
How is MACH2PHYS_NR_ENTRIES not already unsigned long? Or at the very
least how is it not an integer type of some sort, it certainly doesn't
look like it can be a pointer (as suggested by the commit message) to
me.


>       }
>  #ifdef CONFIG_X86_32
>       WARN_ON((machine_to_phys_mapping + (machine_to_phys_nr - 1))



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel