Re: [Xen-devel] [PATCH] Dump IOMMU p2m table

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.08.12 at 18:27, Santosh Jodh <Santosh.Jodh@xxxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> >>> On 14.08.12 at 21:55, Santosh Jodh <santosh.jodh@xxxxxxxxxx> wrote:
>> > +                   (unsigned long)(address >> PAGE_SHIFT_4K),
>> > +                   (unsigned long)(pte->val >> PAGE_SHIFT_4K),
>> > +                   dma_pte_superpage(*pte)? 1 : 0,
>> > +                   dma_pte_read(*pte)? 1 : 0,
>> > +                   dma_pte_write(*pte)? 1 : 0);
>> 
>> Missing spaces. Even worse - given your definitions of these macros
>> there's no point in using the conditional operators here at all.
>> 
>> And, despite your claim in another response, this still isn't similar
>> to AMD's variant (which still doesn't print any of these three
>> attributes).
> 
> I meant structure in terms of recursion logic, level checks etc. I will just 
> remove the extra prints to make it more similar. My original goal was to 
> print it similar to the existing MMU p2m table.

Actually, retaining the read/write information here (and adding it
to AMD's) would be quite useful imo. The superpage part, as said
earlier, needs to be done differently anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel