Re: [Xen-devel] [HYBRID]: status update...

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-08-15 at 09:19 +0100, Jan Beulich wrote:
> >>> On 14.08.12 at 19:51, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> > BTW, being a good hybrid as it is, it uses fields from both pv_domain
> > and hvm_domain structs. Combining into a union created difficulties for
> > me. I experimented creating a new struct, hyb_domain, or adding hvm
> > related fields to pv_domain struct for hybrid, but both involved way too
> > much code change. So back to having them separated again. LMK if there
> > any objections undoing the union.
> 
> I suppose there are going to be fields that are used exclusively
> for PV or HVM, and if so I'd like them to be retained as a union
> as far as possible.

I guess there will be some subset of fields which will be specific to
the use of VT-d/SVM generally but not specifically to the emulation of a
full PC ("HVM") or hybrid mode. I don't know what proportion that would
be but it might be worth splitting along those lines, e.g. pull HW state
out into its own sub-struct and have a union of the true pv-, hvm- and
pvh-only fields?

>  The main point of the change was to shrink
> the size of struct vcpu (which is required to fit into a page,
> which you will need to make sure continues to be the case even
> with all sorts of debugging options turned on).
> 
> Jan
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel