[Xen-devel] bug when using 4K sectors?

[James Harper <james.harper@xxxxxxxxxxxxxxxx>]

I notice this code in drivers/block/xen-blkback/common.h

#define vbd_sz(_v)      ((_v)->bdev->bd_part ? \
                         (_v)->bdev->bd_part->nr_sects : \
                          get_capacity((_v)->bdev->bd_disk))

is the value returned by vbd_sz(_v) the number of sectors in the Linux device 
(eg size / 4096), or the number of 512 byte sectors? I suspect the former which 
is causing block requests beyond 1/8th the size of the device to fail (assuming 
4K sectors are expected to work at all - I can't quite get my head around how 
it would be expected to work - does Linux do the read-modify-write if required?)

I can't test until tomorrow AEDT, but maybe someone here knows the answer 
already?

James

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel