[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 5/5] xen: replace XEN_GUEST_HANDLE with XEN_GUEST_HANDLE_PARAM when appropriate



>>> On 10.08.12 at 14:10, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> 
>>> wrote:
> Note: these changes don't make any difference on x86 and ia64.

I can see your point in doing this in the x86 files nevertheless for
cosmetic/consistency reasons, but I'm really uncertain about this
uglification when it's not really necessary (plus it would shrink the
patch quite a bit).

> Replace XEN_GUEST_HANDLE with XEN_GUEST_HANDLE_PARAM when it is used as
> an hypercall argument.

I didn't look in too close detail, as this isn't intended for the main
branch yet, but I still wasn't able to spot any conversion method
in at least one direction (so that internally these can be passed
around irrespective of their origin).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.