Re: [Xen-devel] [PATCH] dump_p2m_table: For IOMMU

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.08.12 at 03:43, Santosh Jodh <santosh.jodh@xxxxxxxxxx> wrote:
> New key handler 'o' to dump the IOMMU p2m table for each domain.
> Skips dumping table for domain0.
> Intel and AMD specific iommu_ops handler for dumping p2m table.

Looks pretty good now to me, just one minor comment below.
But it will of course need the ack of both the VT-d and AMD IOMMU
maintainers (who, while on Cc, didn't participate in the discussion
so far).

> +    amd_dump_p2m_table_level(hd->root_table, hd->paging_mode, 0, &indent);

Why do you pass a pointer here? Just pass 0, and in the recursive
call pass either +1 or +(level - next_level). (The inconsistency on
the use of next_level will need to be commented on by Wei anyway,
as already requested in an earlier reply.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel