Re: [Xen-devel] [PATCH 4/5] xen: events, exposes evtchn_alloc_unbound_domain

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-08-09 at 11:06 +0100, Tim Deegan wrote:
> At 20:50 +0100 on 03 Aug (1344027053), Jean Guyader wrote:
> > 
> > Exposes evtchn_alloc_unbound_domain to the rest of
> > Xen so we can create allocated unbound evtchn within Xen.
> > 
> > Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxx>
> 
> > @@ -161,18 +163,18 @@ static long 
> > evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc)
> >  {
> >      struct evtchn *chn;
> >      struct domain *d;
> > -    int            port;
> > +    evtchn_port_t  port;
> >      domid_t        dom = alloc->dom;
> > -    long           rc;
> > +    int            rc;
> 
> The function returns long; if you're tidying this up to be an int, might
> as well change the return type too.

I'm not sure if this is relevant but Jan just sent a patch to "make all
(native) hypercalls consistently have "long" return type". I
think/suspect this rc here turns into the result of the hypercall?

Jan's patch was motivated by something to do with sign extension when a
hypercall's int return is written to the long in the multicall arg
struct which causes strangeness. Perhaps not totally relevant to
evtchn_alloc which is unlikely to be in a MC.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel