Re: [Xen-devel] [PATCH 1/5] xen: improve changes to xen_add_to_physmap

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.08.12 at 19:07, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> 
>>> wrote:
> Regarding the name, maybe it should be XEN_ADD_TO_PHYSMAP_FIELD?

Sounds fine (and I like this better than the ..._ARG one you used
below.

> #if (defined(__GNUC__) && !defined(__STRICT_ANSI__)) || (__STDC_VERSION__ >= 
> 201112L)

#if (defined(__GNUC__) && !defined(__STRICT_ANSI__)) || \
    (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 201112L)

avoiding compilers to warn about the use of the possibly
undefined __STDC_VERSION__, which only got introduced
after C89 was already published (and which e.g. gcc indeed
doesn't define if the value would end up being below 199409L).

> # define XEN_ADD_TO_PHYSMAP_ARG
> #else
> # define XEN_ADD_TO_PHYSMAP_ARG u
> #endif

Also, please don't forget to #undef it after use.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel