Re: [Xen-devel] tools/makefile: Add build target

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("[Xen-devel] tools/makefile: Add build target"):
> The alternative is to change the root makefile to call "$(MAKE) -C
> tools/ all" instead, but this way feels neater to me.

Yes.

> tools/makefile: Add build target
> 
> The root Makefile has a build target which calls "$(MAKE) build" in each of 
> xen/
> tools/ stubdom/ and docs/, which fails because of the tools/ Makefile.

That this didn't work is clearly a bug.

But when I tried it my build did this:

  CC    i386-stubdom/eeprom93xx.o
/u/iwj/work/xen-unstable-tools.hg/stubdom/mini-os-x86_32-c/test.o: In function 
`app_main':
/u/iwj/work/xen-unstable-tools.hg/extras/mini-os/test.c:441: multiple 
definition of `app_main'
/u/iwj/work/xen-unstable-tools.hg/stubdom/mini-os-x86_32-c/main.o:/u/iwj/work/xen-unstable-tools.hg/extras/mini-os/main.c:187:
 first defined here
  CC    i386-stubdom/eepro100.o
make[2]: *** 
[/u/iwj/work/xen-unstable-tools.hg/stubdom/mini-os-x86_32-c/mini-os] Error 1
make[2]: Leaving directory `/u/iwj/work/xen-unstable-tools.hg/extras/mini-os'
make[1]: *** [c-stubdom] Error 2
make[1]: *** Waiting for unfinished jobs....

That's the result of:

 (make -j4 build && echo ok.) 2>&1 | tee ../log

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel