Re: [Xen-devel] [xen-unstable test] 13539: regressions - FAIL

[Tim Deegan <tim@xxxxxxx>]

At 08:48 +0100 on 03 Aug (1343983712), Ian Campbell wrote:
> nestedhvm: fix nested page fault build error on 32-bit
> 
>     cc1: warnings being treated as errors
>     hvm.c: In function ???hvm_hap_nested_page_fault???:
>     hvm.c:1282: error: passing argument 2 of 
> ???nestedhvm_hap_nested_page_fault??? from incompatible pointer type 
> /local/scratch/ianc/devel/xen-unstable.hg/xen/include/asm/hvm/nestedhvm.h:55: 
> note: expected ???paddr_t *??? but argument is of type ???long unsigned int 
> *???
> 
> hvm_hap_nested_page_fault takes an unsigned long gpa and passes &gpa
> to nestedhvm_hap_nested_page_fault which takes a paddr_t *. Since both
> of the callers of hvm_hap_nested_page_fault (svm_do_nested_pgfault and
> ept_handle_violation) actually have the gpa which they pass to
> hvm_hap_nested_page_fault as a paddr_t I think it makes sense to
> change the argument to hvm_hap_nested_page_fault.
> 
> The other user of gpa in hvm_hap_nested_page_fault is a call to
> p2m_mem_access_check, which currently also takes a paddr_t gpa but I
> think a paddr_t is appropriate there too.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Tim Deegan <tim@xxxxxxx>

I think this is a candidate for backporting, too.  As Jan points out,
this is a HAP bug on 32-bit with >4G guests.

Tim.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel