[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 5 of 5] makefile: Use $(abspath) for XEN_ROOT

On 31/07/12 17:38, Jan Beulich wrote:
>>>> On 31.07.12 at 17:52, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> This patch wraps the assignment of XEN_ROOT in each Makefile with a call to
>> $(abspath) which removes internal parent path references which result from 
>> the definition of XEN_ROOT as $(CURDIR)../../ (etc).
> Except that it's a make 3.81 invention, and so far we support
> building with make 3.80. So if you want to use it, you'll need to
> provide a fallback implementation (the placement of which may
> turn out to be problematic).
> Jan

Ah - so it is. 

Unfortunately, it appears hard to provide a backwards compatible way of
doing this.  Best to just forget this patch then, although it would be
nice to address this issue somehow in 4.3


>> For example, it changes the output from
>>   gcc readnotes.o -o readnotes
>>   /bind/myrepos/xen-unstable.hg/tools/xcutils/../../tools/libxc/libxenctrl.so
>> /bind/myrepos/xen-unstable.hg/tools/xcutils/../../tools/libxc/libxenguest.so
>> to
>>   gcc readnotes.o -o readnotes 
>> /bind/myrepos/xen-unstable.hg/tools/libxc/libxenctrl.so
>>   /bind/myrepos/xen-unstable.hg/tools/libxc/libxenguest.so
>> which decreases verbosity and increases clarity when reading the build log.
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.