Re: [Xen-devel] [PATCH v2] libxl: enforce prohibitions of internal callers

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH v2] libxl: enforce prohibitions of internal 
callers"):
> On Fri, 2012-07-27 at 17:21 +0100, Ian Jackson wrote:
> 
> > @@ -113,6 +114,15 @@ $(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS) 
> > $(SAVE_HELPER_OBJS): $(AUTOINCS)
> >  genpath-target = $(call buildmakevars2file,_paths.h.tmp)
> >  $(eval $(genpath-target))
> > 
> > +libxl.api-ok: check-libxl-api-rules libxl.api-for-check
> > +       perl $^
> 
> Someone with a BSD hat is about to say "$(PERL)" here I think ;-)
> 
> Otherwise is looks good to me:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Also the commit message should mention the check-libxl-api-rules
script and doesn't.

I will fix this and resend.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel