Re: [Xen-devel] [PATCH 1/2] libxl: fix race in libxl__devices_destroy

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-07-27 at 19:26 +0100, Ian Jackson wrote:

> +void libxl__multidev_prepared(libxl__egc *egc, libxl__ao_devices *aodevs,
> +                              int rc)
> +{
> +    multidev_one_callback(egc, aodevs->preparation);

Don't we need to propagate rc here? Perhaps with 
        aodevs->preparation->rc= rc
?

> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index f0c94e8..7072b09 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -1810,20 +1810,6 @@ typedef void libxl__device_callback(libxl__egc*, 
> libxl__ao_device*);
[...]
> +/*
> + * Multiple devices "multidevs" handling.
> + *
> + * Firstly, you should
> + *    libxl__multidev_begin
> + *    multidevs->callback = ...
> + * Then zero or more times
> + *    libxl__multidev_prepare
> + *    libal__initiate_device_{remove/addition}.
> + * Finally, once
> + *    libxl__multidev_prepared
> + * which will result (perhaps reentrantly) in one call to callback().

Briefly mention the multidev vs ao_devices naming? Or just do the rename
now in a new patch.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel