Re: [Xen-devel] [PATCH] libxl: support custom block hotplug scripts

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-07-27 at 16:58 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH] libxl: support custom block hotplug scripts"):
> > diff -r 006588b1bbb6 -r 9357ff928a35 tools/libxl/libxlu_disk_l.l
> > --- a/tools/libxl/libxlu_disk_l.l       Thu Jul 26 17:11:07 2012 +0100
> > +++ b/tools/libxl/libxlu_disk_l.l       Fri Jul 27 15:21:19 2012 +0100
> > @@ -66,7 +66,7 @@ void xlu__disk_yyset_column(int  column_
> > 
> >  /* Sets a string value, checking it hasn't been set already. */
> >  #define SAVESTRING(what,loc,val) do{                                   \
> > -       savestring(DPC, what " respecified", &DPC->disk->loc, (val));   \
> > +       savestring(DPC, what " respecified", &DPC->disk->loc, val);     \
> 
> This is surely a mistake.

Failure to qrefresh to undo the mistake which I had noticed and
corrected before sending :-/

> As for the meat, we had a conversation in person.
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel