Re: [Xen-devel] [PATCH v2 4/6] xen/arm: implement get/put_page_type

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 24 Jul 2012, Ian Campbell wrote:
> On Tue, 2012-07-24 at 11:27 +0100, Stefano Stabellini wrote:
> > > In fact, do the types make any sense at all for ARM? Is PGT_writable is
> > > really only meaningful when you have direct paging?
> > 
> > I am starting to think that a better way to implement get_page_type is:
> > 
> > int get_page_type(struct page_info *page, unsigned long type)
> > {
> >     return 1;
> > }
> 
> Would you need to take/release a regular reference count too? Or does
> common code always ensure it has a normal reference when manipulating
> types?

It seems to me that the common code always takes a normal reference to
the page before increasing the typecount.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel