Re: [Xen-devel] [PATCH v8] Some automatic NUMA placement documentation

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dario Faggioli writes ("[PATCH v8] Some automatic NUMA placement 
documentation"):
> About rationale, usage and (some small bits of) API.

> +Also, if `numa_placement` is set to `true`, the domain must not
> +have any cpu affinity (i.e., `domain_build_info->cpumap` must
> +have all its bits set, as it is by default), or domain creation
> +will fail returning `ERROR_INVAL`.

This is no longer true, is it ?

And:

> +Analyzing various possible placement solutions is what makes the
> +algorithm flexible and quite effective. However, that also means
> +it won't scale well to systems with arbitrary number of nodes.
> +For this reason, if machines with more than 16 NUMA nodes will
> +ever exist, placement will automatically disables itself when
> +running libxl on them.

This last is very awkwardly phrased.  How about:

   For this reason, automatic numa placement is disabled (with
   a warning) if it is requested on a host with more than 16 NUMA
   nodes.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel