Re: [Xen-devel] [PATCH v13 04/11] libxl: convert libxl_device_disk_add to an async op

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-07-26 at 15:55 +0100, Roger Pau Monne wrote:
> @@ -2145,11 +2146,13 @@ int libxl_cdrom_insert(libxl_ctx *ctx,
> uint32_t domid, libxl_device_disk *disk)
>      ret = 0;
> 
>      libxl_device_disk_remove(ctx, domid, disks + i, 0);
> -    libxl_device_disk_add(ctx, domid, disk);
> +    /* fixme-ao */
> +    libxl_device_disk_add(ctx, domid, disk, 0);
>      stubdomid = libxl_get_stubdom_id(ctx, domid);
>      if (stubdomid) {
>          libxl_device_disk_remove(ctx, stubdomid, disks + i, 0);
> -        libxl_device_disk_add(ctx, stubdomid, disk);
> +        /* fixme-ao */
> +        libxl_device_disk_add(ctx, stubdomid, disk, 0);

This hunk is not needed any more after 25670:3666e9712eaf. The correct
fix is just to drop it and I'll do this as I apply.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel