Re: [Xen-devel] [PATCH] serial: don't waste space allocated for the tx buffer(s)

[Keir Fraser <keir@xxxxxxx>]

On 26/07/2012 16:05, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> We're allocating minimally a full page, so no reason to not also use
> all that space.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

> --- a/xen/drivers/char/serial.c
> +++ b/xen/drivers/char/serial.c
> @@ -483,8 +483,8 @@ void __init serial_async_transmit(struct
>      BUG_ON(!port->driver->tx_empty);
>      if ( port->txbuf != NULL )
>          return;
> -    if ( serial_txbufsz < 512 )
> -        serial_txbufsz = 512;
> +    if ( serial_txbufsz < PAGE_SIZE )
> +        serial_txbufsz = PAGE_SIZE;
>      while ( serial_txbufsz & (serial_txbufsz - 1) )
>          serial_txbufsz &= serial_txbufsz - 1;
>      port->txbuf = alloc_xenheap_pages(
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel