Re: [Xen-devel] [PATCH 0/2] xl: handle empty xl cdrom devices in xend syntax

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-07-25 at 16:21 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] xl: support empty CDROM 
> devices"):
> > On Wed, 2012-07-25 at 11:47 +0100, Ian Jackson wrote:
> > > Maybe it would be better to do something ad hoc.  I have an idea which
> > > I will try to implement...
> > 
> > OK.
> 
> This seems to have worked.

Cool

>   Here is the result.  This patch
>  - contains a copy of some your empty disk format tests
>  - when applied to -unstable only passes the tests if your
>   +        if (!disk->pdev_path || !strcmp(disk->pdev_path, ""))
>   +            disk->format = LIBXL_DISK_FORMAT_EMPTY;
>    is included and the references to the `empty' disks are
>    commented out from check-xl-disk-parse.

I'm not sure what specifically you have commented out here. so...

> Did you want me to merge it properly with yours ?

... I think this might be a good idea rather than have me make a mess of
it.

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel