Re: [Xen-devel] [PATCH v11 15/17] libxl: convert libxl_device_vfb_add to an async operation

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v11 15/17] libxl: convert 
> libxl_device_vfb_add to an async operation"):
>> Split libxl_device_vfb_add into libxl__device_vfb_add (to be used
>> inside already running ao's), and make libxl_device_vfb_add a stub
>> to call libxl__device_vfb_add.
>>
>> Once the device has been added to xenstore, libxl waits for it to
>> reach state 2 (InitWait).
> 
> We will need to test this but it looks reasonable then.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

I'm not going to take the Ack for this, because I've simplified
libxl__device_vfb_add to not take any aodev/ao, since there's no point
in waiting for vfb/vkb devices to switch to state 2 because we are not
going to execute any hotplug script (as we spoke yesterday).

The resulting patch is much more simple, sorry for the double work, and
thanks for the review.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel