Re: [Xen-devel] [PATCH v10 13/19] libxl: set correct nic type depending on the guest

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v10 13/19] libxl: set correct nic type 
depending on the guest"):
> Fix the use of nic type, which results in the following for each type
> of domain:
...> 
>  * HVM: let the user choose, if none specified use VIF_IOEMU.
>  * PV: use VIF always.

I think attempts by the user to use VIF_IOEMU with a PV domain should
be rejected with ERROR_INVAL, not silently ignored.

> -int libxl__device_nic_setdefault(libxl__gc *gc, libxl_device_nic *nic)
> +int libxl__device_nic_setdefault(libxl__gc *gc, libxl_device_nic *nic,
> +                                 uint32_t domid)
...
> +    case LIBXL_DOMAIN_TYPE_PV:
> +        nic->nictype = LIBXL_NIC_TYPE_VIF;
> +        break;

Somewhere here.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel