Re: [Xen-devel] [PATCH v10 06/19] libxl: refactor disk addition to take a helper

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v10 06/19] libxl: refactor disk addition to 
take a helper"):
> Change libxl__device_disk_add to no longer take a xs transaction and
> instead pass a helper for the local attach case that's used to get the
> free vdev.
> 
> This function contains some non-functional changes due to an
> indentation change.
...
> +/* Specific function called directly only by local disk attach,
> + * all other users should instead use the regular
> + * libxl__device_disk_add wrapper
> + *
> + * The (optionally) passed function get_vdev_user will be used to
> + * set the vdev the disk should be attached to. When it is set the caller
> + * must also pass blkdev_start, which will be passed to get_vdev_user.
> + *
> + * The passed get_vdev_user function is also in charge of printing
> + * the corresponding error message when appropiate.
> + */
> +static int device_disk_add(libxl__gc *gc, uint32_t domid,
> +                           libxl_device_disk *disk,
> +                           void *get_vdev_user(libxl__gc *, const char *,
> +                                               xs_transaction_t),
> +                           const char *blkdev_start)

Uh, I meant:
  +                           char *get_vdev(libxl__gc *, void *user,
  +                                               xs_transaction_t),
  +                           void *get_vdev_user)

I was trying to suggest that device_disk_add shouldn't need to know
the meaning of the parameter which you've called blkdev_start.

I think what you have now is even odder than before.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel