Re: [Xen-devel] [PATCH v10 15/19] libxl: call hotplug scripts for disk devices from libxl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-07-20 at 15:12 +0100, Roger Pau Monne wrote:
> +    if (status) {
> +        libxl_report_child_exitstatus(CTX, LIBXL__LOG_ERROR,
> +                                      aodev->what, pid, status);
> +        hotplug_error = libxl__xs_read(gc, XBT_NULL,
> +                                       GCSPRINTF("%s/hotplug-error", 
> be_path));
> +        if (hotplug_error)
> +            LOG(ERROR, "reason of failure reported by hotplug script: %s",
> +                       hotplug_error); 

This should be "reason *for* failure" but actually it's rather verbose,
the log line is ~100 chars before you even append hotplug_error. I think
just a "script: " prefix, or even nothing, would be ok.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel