Re: [Xen-devel] [PATCH 1 of 3 v4/leftover] libxl: enable automatic placement of guests on NUMA nodes

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH 1 of 3 v4/leftover] libxl: enable automatic 
placement of guests on NUMA nodes"):
> On Tue, 2012-07-17 at 16:55 +0100, Ian Jackson wrote:
> > 1. This macro max() should be in libxl_internal.h.
> > 2. It should be MAX so people are warned it's a macro
> > 3. It should have all the necessary ()s for macro precedence safety
> 
> You probably also want to do the necessary tricks to avoid multiple
> evaluation of the arguments?

Those tricks are a pain.  I think in general macros are `allowed' to
do this provided their names are SHOUTY.  That's why it should be
called `MAX'.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel