Re: [Xen-devel] [PATCH v8 00/15] execute hotplug scripts from libxl

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2012-07-10 at 13:23 -0400, Roger Pau Monne wrote:
> Ian Campbell wrote:
> > On Tue, 2012-07-10 at 12:07 -0400, Roger Pau Monne wrote:
> > 
> >> I'm working on making vfb/vkb async, once that is done I can take a look
> >> on this,
> > 
> > Cool. BTW is the other stuff ready? I guess it is waiting on IanJ to
> > review again?
> 
> I've changed the series according to your comments, and I'm waiting for
> IanJ review. I also have NetBSD hotplug & vfb/vkb series ready, that
> will come after this is committed. If you want I can start posting them,
> I didn't do so yet because they depend a lot on this.

I think there's no harm in posting stuff earlier if it is ready.
Especially since ian J and myself are at debconf and unlikely to be
doing a whole lot of review etc.

> >>  but since the device removal is done after Qemu has been killed
> >> I don't have much expectations that this is going to work (at least for
> >> the shutdown/destroy case).
> > 
> > Right, that's an interesting problem. I wonder if qemu should set state
> > = 5 (or 6?) for all its backends as it does a graceful shutdown?
> 
> Sorry, what I've said is not accurate. Qemu sets state to "closed" on
> shutdown/destroy, what doesn't seem to work is the disconnection by
> setting online to 0 or status to 5 while Qemu is running.
> 
> Maybe we should not call libxl_device_disk_add/remove when the backend
> is Qemu for cdrom_insert and instead perform the params remove/addition
> that you exposed before directly on cdrom_insert.

yes, precisely. I've got half a skanky patch to do this ...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel