Re: [Xen-devel] [PATCH 00 of 10 v3] Automatic NUMA placement for xl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-07-06 at 12:16 +0100, Ian Campbell wrote:
> There are a few "goto out"s before initialising that variable, but none
> of them log (really they should) and I didn't investigate which one it
> was yet.

It seems to be:
   /* If we don't have at least 2 nodes, it is useless to proceed */
    if (nr_nodes < 2) {
        LOG(DEBUG, "only %d node. no placement required", nr_nodes);
        rc = 0;
        goto out;
    }

(LOG is mine...). The other exit paths look like the log further down
the stack but not this one so it is worth adding.

You probably want another libxl_bitmap_init near the top of the
function.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel