Re: [Xen-devel] [PATCH] Xen/MCE: adjust for future new vMCE model

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Luck, Tony wrote:
>> I'm not sure if AMD has these 2 bits in MCG_CAP. Could you tell me
>> where can I get 
>> AMD's *latest* open doc (something like amd architecture programmer
>> manual)? 
>> 
>> If AMD has these 2 bits, it's safe to set them independent of host
>> capability -- guest 
>> will just think it running on a platform w/ some events *possilbe*
>> (though actually 
>> may never occur), hypervisor know what actually occur and has the
>> flexibility to 
>> decide what it would like to inject to guest.
>> 
>> This code is only used by Intel, and it's only for not blocking
>> future vMCE, so it just do minimal necessary update. 
> 
> I think you should be very wary of creating "Franken-machines" that
> look half AMD (according to CPUID) and half Intel (according to
> MCG_CAP). You can look at the Linux code and check whether we always
> make sensible decisions when presented with 
> such a system ... but you may not have that luxury with other guest
> operating systems. My general mantra is that untested code paths have
> bugs. 
> 
> -Tony

Yes, I indeed concern AMD cpuid vs. Intel MCG_CAP. Do you suggest that we'd 
better separately provide Intel's and AMD's vMCE interface?

Thanks,
Jinsong
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel