Re: [Xen-devel] [PATCH WIP 2/5] xen/arm: set xen_platform_pci_unplug to XEN_UNPLUG_ALL

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 04/07/12 12:15, Stefano Stabellini wrote:
> Set xen_platform_pci_unplug to XEN_UNPLUG_ALL by default to make
> blkfront happy. The parameter doesn't make sense on ARM and should be
> removed.

Why is this parameter nonsensical on ARM?  ARM systems can have PCI devices.

David

> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> ---
>  arch/arm/xen/enlighten.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 6901e37..a6dc9eb 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -8,6 +8,7 @@
>  #include <xen/grant_table.h>
>  #include <xen/hvm.h>
>  #include <xen/xenbus.h>
> +#include <xen/platform_pci.h>
>  
>  #include <linux/module.h>
>  
> @@ -33,7 +34,7 @@ __read_mostly int xen_have_vector_callback;
>  EXPORT_SYMBOL_GPL(xen_have_vector_callback);
>  
>  /* XXX: to be removed */
> -int xen_platform_pci_unplug;
> +int xen_platform_pci_unplug = XEN_UNPLUG_ALL;
>  EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
>  
>  #define FOREIGN_MAP_BUFFER 0x90000000UL


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel