[Xen-devel] [PATCH 3/4] xen/acpi: Fix potential memory leak.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

Coverity points out that we do not free in one case the
pr_backup - and sure enough we forgot.

Found by Coverity (CID 401970)

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
---
 drivers/xen/xen-acpi-processor.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c
index 7ff2569e..b590ee0 100644
--- a/drivers/xen/xen-acpi-processor.c
+++ b/drivers/xen/xen-acpi-processor.c
@@ -520,15 +520,18 @@ static int __init xen_acpi_processor_init(void)
 
                if (!pr_backup) {
                        pr_backup = kzalloc(sizeof(struct acpi_processor), 
GFP_KERNEL);
-                       memcpy(pr_backup, _pr, sizeof(struct acpi_processor));
+                       if (pr_backup)
+                               memcpy(pr_backup, _pr, sizeof(struct 
acpi_processor));
                }
                (void)upload_pm_data(_pr);
        }
        rc = check_acpi_ids(pr_backup);
-       if (rc)
-               goto err_unregister;
 
        kfree(pr_backup);
+       pr_backup = NULL;
+
+       if (rc)
+               goto err_unregister;
 
        return 0;
 err_unregister:
-- 
1.7.7.6


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel