Re: [Xen-devel] [PATCH v6 00/13] execute hotplug scripts from libxl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-06-14 at 13:21 +0100, Roger Pau Monne wrote:
...

I'm afraid that something in this series appears to break stub-dm
support.

It looks like you need to add code to
libxl__domain_create_info_setdefault to set cinfo->run_hotplug_scripts
to a specific default.

        quartz:~# gdb --args xl -vvv cr -F /etc/xen/debian-HVM-1 
        [...]
        Reading symbols from /usr/sbin/xl...done.
        (gdb) r
        Starting program: /usr/sbin/xl -vvv cr -F /etc/xen/debian-HVM-1
        [Thread debugging using libthread_db enabled]
        Parsing config from /etc/xen/debian-HVM-1
        libxl: debug: libxl_create.c:1135:do_domain_create: ao 0x806a088: 
create: how=(nil) callback=(nil) poller=0x8069728
        libxl: debug: libxl_device.c:253:libxl__device_disk_set_backend: Disk 
vdev=hda spec.backend=unknown
        libxl: debug: libxl_device.c:289:libxl__device_disk_set_backend: Disk 
vdev=hda, using backend phy
        libxl: debug: libxl_create.c:665:initiate_domain_create: running 
bootloader
        libxl: debug: libxl_bootloader.c:324:libxl__bootloader_run: not a PV 
domain, skipping bootloader
        libxl: debug: libxl_event.c:561:libxl__ev_xswatch_deregister: watch 
w=0x806a278: deregister unregistered
        xc: detail: elf_parse_binary: phdr: paddr=0x100000 memsz=0x9bca4
        xc: detail: elf_parse_binary: memory: 0x100000 -> 0x19bca4
        xc: info: VIRTUAL MEMORY ARRANGEMENT:
          Loader:        0000000000100000->000000000019bca4
          TOTAL:         0000000000000000->0000000007800000
          ENTRY ADDRESS: 0000000000100000
        xc: info: PHYSICAL MEMORY ALLOCATION:
          4KB PAGES: 0x0000000000000200
          2MB PAGES: 0x000000000000003b
          1GB PAGES: 0x0000000000000000
        xc: detail: elf_load_binary: phdr 0 at 0x0xb7cc7000 -> 0x0xb7d59b14
        libxl: debug: libxl_device.c:253:libxl__device_disk_set_backend: Disk 
vdev=hda spec.backend=phy
        libxl: debug: libxl_event.c:512:libxl__ev_xswatch_register: watch 
w=0x806af2c wpath=/local/domain/0/backend/vbd/10/768/state token=3/0: register 
slotnum=3
        [New Thread 0xb7fddb70 (LWP 5177)]
        libxl: debug: libxl_create.c:1148:do_domain_create: ao 0x806a088: 
inprogress: poller=0x8069728, flags=i
        libxl: debug: libxl_event.c:457:watchfd_callback: watch w=0x806af2c 
wpath=/local/domain/0/backend/vbd/10/768/state token=3/0: event 
epath=/local/domain/0/backend/vbd/10/768/state
        libxl: debug: libxl_event.c:596:devstate_watch_callback: backend 
/local/domain/0/backend/vbd/10/768/state wanted state 2 ok
        libxl: debug: libxl_event.c:549:libxl__ev_xswatch_deregister: watch 
w=0x806af2c wpath=/local/domain/0/backend/vbd/10/768/state token=3/0: 
deregister slotnum=3
        libxl: debug: libxl_event.c:561:libxl__ev_xswatch_deregister: watch 
w=0x806af2c: deregister unregistered
        libxl: debug: libxl_device.c:806:device_hotplug: calling hotplug 
script: /etc/xen/scripts/block add
        libxl: debug: libxl_event.c:426:watchfd_callback: watch 
epath=/local/domain/0/backend/vbd/10/768/state token=3/0: empty slot
        xl: libxl.c:252: libxl_defbool_val: Assertion 
`!libxl_defbool_is_default(db)' failed.
        
        Program received signal SIGABRT, Aborted.
        0xff7fe424 in __kernel_vsyscall ()
        (gdb) bt
        #0  0xff7fe424 in __kernel_vsyscall ()
        #1  0xb7e1d781 in *__GI_raise (sig=6) at 
../nptl/sysdeps/unix/sysv/linux/raise.c:64
        #2  0xb7e20bb2 in *__GI_abort () at abort.c:92
        #3  0xb7e168e8 in *__GI___assert_fail (
            assertion=0xb7fbe96c "!libxl_defbool_is_default(db)", 
file=0xb7fbe54c "libxl.c", 
            line=252, function=0xb7fc06a3 "libxl_defbool_val") at assert.c:81
        #4  0xb7f8d121 in libxl_defbool_val (db=...) at libxl.c:252
        #5  0xb7f9709e in libxl__domain_make (gc=0x806a098, info=0x806a3d4, 
domid=0x806a618)
            at libxl_create.c:518
        #6  0xb7f9aa85 in libxl__spawn_stub_dm (egc=0xbffff39c, sdss=0x806a358) 
at libxl_dm.c:782
        #7  0xb7f96493 in domcreate_launch_dm (egc=0xbffff39c, 
aodevs=0x806a750, rc=0)
            at libxl_create.c:956
        #8  0xb7fa5a27 in libxl__ao_devices_callback (egc=0xbffff39c, 
aodev=0x806af08)
            at libxl_device.c:464
        #9  0xb7fa69c7 in device_hotplug_done (egc=<value optimized out>, 
aodev=0x806af08)
            at libxl_device.c:900
        #10 0xb7fa6c85 in device_hotplug (egc=<value optimized out>, 
aodev=0x806af08)
            at libxl_device.c:829
        #11 0xb7fa6d0a in device_hotplug_child_death_cb (egc=0xbffff39c, 
child=0x806af80, 
            pid=5180, status=0) at libxl_device.c:870
        #12 0xb7fb45db in childproc_reaped (egc=0xbffff39c, pid=6, status=0) at 
libxl_fork.c:264
        #13 0xb7fb4c57 in libxl__fork_selfpipe_woken (egc=0xbffff39c) at 
libxl_fork.c:300
        #14 0xb7fb122c in afterpoll_internal (egc=0xbffff39c, poller=<value 
optimized out>, 
            nfds=3, fds=0x8071198, now=...) at libxl_event.c:901
        #15 0xb7fb1edb in eventloop_iteration (egc=<value optimized out>, 
poller=0x8069728)
            at libxl_event.c:1305
        #16 0xb7fb254f in libxl__ao_inprogress (ao=0x806a088, file=0xb7fc0a27 
"libxl_create.c", 
            line=1148, func=0xb7fc0c80 "do_domain_create") at libxl_event.c:1551
        #17 0xb7f9877b in do_domain_create (ctx=<value optimized out>, 
            d_config=<value optimized out>, domid=0x8067f34, restore_fd=-1, 
ao_how=0x0, 
            aop_console_how=0x0) at libxl_create.c:1148
        #18 0xb7f98877 in libxl_domain_create_new (ctx=0x8069030, 
d_config=0xbffff5a8, 
            domid=0x8067f34, ao_how=0x0, aop_console_how=0x0) at 
libxl_create.c:1169
        #19 0x080538d2 in create_domain (dom_info=<value optimized out>) at 
xl_cmdimpl.c:1796
        #20 0x0805ce8f in main_create (argc=3, argv=0xbffffd2c) at 
xl_cmdimpl.c:3761
        #21 0x0804d1be in main (argc=5, argv=0xbffffd24) at xl.c:267
        
        


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel