Re: [Xen-devel] [PATCH 1/5] xen: add ssize_t

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.06.12 at 12:09, Jean Guyader <jean.guyader@xxxxxxxxx> wrote:
> On 29 June 2012 09:05, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 28.06.12 at 18:26, Jean Guyader <jean.guyader@xxxxxxxxxx> wrote:
>>
>> If this is really needed (which I doubt, looking at the two users
>> and their - respectively - sole callers), then for x86 please put
>> the definitions alongside the size_t ones.
>>
>> Until the need for the type is shown, this is a NAK from me.
>>
> 
> The ssize_t can't be replaced with a size_t because the functions that use 
> it can return negative number and size_t is unsigned.

Did you really look at the users? One stores the ssize_t value
in a uint32_t (losing the signedness), and the other stores it
into an int (losing the wider size).

> ssize_t could be replaced by a long long which will work for all the
> case 32 and 64b.

A long would do as well.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel