Re: [Xen-devel] [xen-unstable test] 13385: regressions - FAIL

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 13385: regressions - 
FAIL"):
> In file included from libxl_save_helper.c:44:
> libxl.h:346:26: error: _libxl_types.h: No such file or directory

Thanks for looking into this.  I guess it WFM because I normally have
everything in ccache, and I'm just (un)lucky.

> libxl: make libxl-save-helper depend on the autogenerated code targets

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> diff -r 0455d8317631 -r c5b08c577c7f tools/libxl/Makefile
...
> -$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): $(AUTOINCS)
> +$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS) $(SAVE_HELPER_OBJS): $(AUTOINCS)

This part is of course the entirely correct fix; I should have done
this.

> -$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h
> +$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS) $(SAVE_HELPER_OBJS): libxl.h
>  $(LIBXL_OBJS): libxl_internal.h

This part is mad but currently necessary.  The root cause of the
problem is, as you guessed (pers. comm.), this:

  libxl.h: _libxl_types.h
  libxl_json.h: _libxl_types_json.h
  libxl_internal.h: _libxl_types_internal.h _paths.h
  libxl_internal_json.h: _libxl_types_internal_json.h

and this:

  AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
        _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h

Note lack of _libsl_types*.h.

I think we can wait with fixing this until post-4.2.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel