Re: [Xen-devel] [PATCH v6 10/13] libxl: set nic type to VIF by default

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-06-28 at 11:07 +0100, Roger Pau Monne wrote:
> Ian Campbell wrote:
> > On Thu, 2012-06-28 at 10:41 +0100, Roger Pau Monne wrote:
> >> I think the most suitable place is
> >> libxl_create.c:initiate_domain_create, which also sets the defaults for
> >> disk devices,
> >
> > .. by calling setdefaults though.
> 
> Yes, sorry.
> 
> >
> > I'd like to keep all such logic in setdefaults as far as possible.
> >
> > libxl__devic_nic_setdefautls is an internal function so we can add
> > either a domid or type parameter quite easily. Are there any callsites
> > which would be unable to provide one or the other of those?
> >
> > Probably domid is best, with setdefaults calling libxl__domain_type as
> > necessary.
> 
> I think it would be appropriate to pass domid to every setdefault 
> function, even if it's only used by nic now:
> 
> libxl__device_disk_setdefault
> libxl__device_nic_setdefault
> libxl__device_vfb_setdefault
> libxl__device_vkb_setdefault
> libxl__device_pci_setdefault
> 
> To keep the symmetry, are you ok with that?

Lets make that cleanup in 4.3 and just do the necessary for 4.2.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel