Re: [Xen-devel] [PATCH v3 00/18] libxl: domain save/restore: run in a separate process

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH v3 00/18] libxl: domain 
save/restore: run in a separate process"):
> On Fri, 2012-06-15 at 12:53 +0100, Ian Jackson wrote:
> > This is v4 of my series to asyncify save/restore.  All comments have
> > been addressed.
> 
> Building with this I get:
>         cc1: warnings being treated as errors
>         libxl.c: In function âlibxl_domain_destroyâ:
>         libxl.c:1224: error: âdm_presentâ may be used uninitialized in this 
> function
>         
> I expect because for some reason gcc doesn't realise that the switch
> covers all possible enum values (since the cases all either initialise
> or jump to out which does not use dm_present).

How annoying.

> In order that I could continue to test I did this:
> 
> diff -r fca1330fa367 tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c     Fri Jun 22 13:19:22 2012 +0100
> +++ b/tools/libxl/libxl.c     Fri Jun 22 13:22:25 2012 +0100
> @@ -1244,6 +1244,7 @@ int libxl_domain_destroy(libxl_ctx *ctx,
>      case LIBXL_DOMAIN_TYPE_INVALID:
>          rc = ERROR_FAIL;
>          goto out;
> +    default: abort();
>      }
>  
>      dom_path = libxl__xs_get_dompath(gc, domid);
> 
> but you might have a better preference.

Thanks, I have done that.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel