Re: [Xen-devel] [PATCH 2 of 3] tools/m4: add AC_LANG_SOURCE to fix autoconf warnings

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-06-13 at 14:10 +0100, Olaf Hering wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1339593008 -7200
> # Node ID 59762b446ab4e6d9a851a91d1457c11f6c828d49
> # Parent  0dfe08c91739527eb454d5e4957635cb8b90e1e1
> tools/m4: add AC_LANG_SOURCE to fix autoconf warnings
> 
> I see these warnings with autoconf 2.68, add AC_LANG_SOURCE as suggested
> by upstream documentation.
> 
> ...
>  # bash autogen.sh
> configure.ac:141: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected 
> in body
> ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
> ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from...
> ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...
> ../../lib/m4sugar/m4sh.m4:606: AS_IF is expanded from...
> ../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from...
> ../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from...
> m4/pthread.m4:21: AX_CHECK_PTHREAD is expanded from...
> configure.ac:141: the top level
> configure.ac:142: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected 
> in body
> ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
> ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from...
> ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...
> ../../lib/m4sugar/m4sh.m4:606: AS_IF is expanded from...
> ../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from...
> ../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from...
> m4/ptyfuncs.m4:1: AX_CHECK_PTYFUNCS is expanded from...
> configure.ac:142: the top level
> configure.ac:141: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected 
> in body
> ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
> ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from...
> ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...
> ../../lib/m4sugar/m4sh.m4:606: AS_IF is expanded from...
> ../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from...
> ../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from...
> m4/pthread.m4:21: AX_CHECK_PTHREAD is expanded from...
> configure.ac:141: the top level
> configure.ac:142: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected 
> in body
> ../../lib/autoconf/lang.m4:194: AC_LANG_CONFTEST is expanded from...
> ../../lib/autoconf/general.m4:2662: _AC_LINK_IFELSE is expanded from...
> ../../lib/autoconf/general.m4:2679: AC_LINK_IFELSE is expanded from...
> ../../lib/m4sugar/m4sh.m4:606: AS_IF is expanded from...
> ../../lib/autoconf/general.m4:2032: AC_CACHE_VAL is expanded from...
> ../../lib/autoconf/general.m4:2053: AC_CACHE_CHECK is expanded from...
> m4/ptyfuncs.m4:1: AX_CHECK_PTYFUNCS is expanded from...
> configure.ac:142: the top level
> 
> 
> Please rerun autoconf after applying this.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> diff -r 0dfe08c91739 -r 59762b446ab4 tools/m4/pthread.m4
> --- a/tools/m4/pthread.m4
> +++ b/tools/m4/pthread.m4
> @@ -24,13 +24,13 @@ AC_DEFUN([AX_CHECK_PTHREAD],[
>          AX_PTHREAD_CV2VARS
>          AX_PTHREAD_VARS([AX_SAVEVAR_SAVE])
>          AX_PTHREAD_VARS([AX_PTHREAD_VAR_APPLY])
> -        AC_LINK_IFELSE([
> +        AC_LINK_IFELSE([AC_LANG_SOURCE([
>  #include <pthread.h>
>  int main(void) {
>    pthread_atfork(0,0,0);
>    pthread_create(0,0,0,0);
>  }
> -],[],[ax_cv_pthread_flags=failed])
> +])],[],[ax_cv_pthread_flags=failed])
>          AX_PTHREAD_VARS([AX_SAVEVAR_RESTORE])
>      ])
>      if test "x$ax_cv_pthread_flags" = xfailed; then
> diff -r 0dfe08c91739 -r 59762b446ab4 tools/m4/ptyfuncs.m4
> --- a/tools/m4/ptyfuncs.m4
> +++ b/tools/m4/ptyfuncs.m4
> @@ -9,7 +9,7 @@ AC_DEFUN([AX_CHECK_PTYFUNCS], [
>              fi
>              AX_SAVEVAR_SAVE(LIBS)
>              LIBS="$LIBS $ax_cv_ptyfuncs_libs"
> -            AC_LINK_IFELSE([
> +            AC_LINK_IFELSE([AC_LANG_SOURCE([
>  #ifdef INCLUDE_LIBUTIL_H
>  #include INCLUDE_LIBUTIL_H
>  #endif
> @@ -17,7 +17,7 @@ int main(void) {
>    openpty(0,0,0,0,0);
>    login_tty(0);
>  }
> -],[
> +])],[
>                  break
>              ],[])
>              AX_SAVEVAR_RESTORE(LIBS)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel