Re: [Xen-devel] [PATCH v6 07/13] libxl: convert libxl_device_nic_add to an async operation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-06-22 at 12:37 +0100, Ian Jackson wrote:
> 
> > -DEFINE_DEVICES_ADD(disk)
> > +DEFINE_DEVICES_ADD(disk, disk)
> > +DEFINE_DEVICES_ADD(vif, nic)
> 
> it seems to me that this is an anomaly which might be better fixed
> than worked around.
> 
> Should we rename the functions libxl_*nic* or the structures *vif* ?
> Or should we rename both, to "net" perhaps ?

If its a simple sed then I guess libxl_device_nic* is the answer -- but
if it turns into another yakk shaving exercise then perhaps we can just
live with it how it is.

libxl_device_net would also have been acceptable but doesn't seem as
analogous to libxl_device_disk to me and would have involved changing
both halves.

I don't like libxl_device_vif -- that's more an implementation thing --
cf. the TYOE_IOEMU vs TYPE_VIF conversation...

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel