[Xen-devel] [PATCH 2 of 5] libxl: initialise cpupoolinfo in libxl__domain_scheduler

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1340362527 -3600
# Node ID b6a78743e13fb5b7f652f25a541eb425a21f1396
# Parent  998d48ccb8905907cb2f104b475e5ab6ad445348
libxl: initialise cpupoolinfo in libxl__domain_scheduler

If libxl_cpupool_info fails then we would call
libxl_cpupoolinfo_dispose on an uninitialised struct, and possibly
free an invalid pointer.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 998d48ccb890 -r b6a78743e13f tools/libxl/libxl_dom.c
--- a/tools/libxl/libxl_dom.c   Fri Jun 22 11:41:43 2012 +0100
+++ b/tools/libxl/libxl_dom.c   Fri Jun 22 11:55:27 2012 +0100
@@ -84,6 +84,7 @@ libxl_scheduler libxl__domain_scheduler(
     if (cpupool < 0)
         return sched;
 
+    libxl_cpupoolinfo_init(&poolinfo);
     rc = libxl_cpupool_info(CTX, &poolinfo, cpupool);
     if (rc < 0)
         goto out;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel