[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] tools: honour --libdir when it is passed to ./configure
Matt Wilson wrote: On Wed, Jun 20, 2012 at 09:44:13AM -0700, Wilson, Matt wrote:On Wed, Jun 20, 2012 at 01:51:17AM -0700, Roger Pau Monne wrote:Matt Wilson wrote:+CFLAGS += -Wno-unknown-pragmas -I$(XEN_ROOT)/tools/libfsimage/common/ -DFSIMAGE_FSDIR=\"$(FSDIR)\"I would prefer to set FSIMAGE_FSDIR or an equivalent define in tools/config.h and include that header in tools/libfsimage/common/fsimage_plugin.h, so we don't have to pass that value from the compiler command line.It turns out to be tricky to do this, since you have to recursively expand the value from libdir="${exec_prefix}/lib". Also, it's counter to the generally accepted pattern for passing these types of variables down when using autoconf, which actually is to use -D in CFLAGS. See also this thread: http://stackoverflow.com/questions/5867136/autoconf-how-to-get-installation-paths-into-config-h Fair enough, thanks. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |