Re: [Xen-devel] [PATCH 07/19] libxl: provide libxl__xs_*_checked and libxl__xs_transaction_*

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH 07/19] libxl: provide 
libxl__xs_*_checked and libxl__xs_transaction_*"):
> On Fri, 2012-06-08 at 18:34 +0100, Ian Jackson wrote:
> > These useful utility functions make dealing with xenstore a little
> > less painful.
> > 
> > Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks.

> (minor observation and a typo below)
...
> > +int libxl__xs_write_checked(libxl__gc *gc, xs_transaction_t t,
> > +                            const char *path, const char *string);
> 
> I suppose in the future we might consider merging this with
> libxl__xs_write -- there's no reason not to always log a failed write,
> is there?

Maybe.  It might fail due to EPERM and there might be another strategy
the caller might have available.  Although this is rare enough that
perhaps such callers should use raw xs calls.

Arguably the same applies to read.

> > + *    0  commited successfully
> 
>            committed

Fixed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel