Re: [Xen-devel] [PATCH 1 of 4 RFC] xen, p2m: get_entry returns level of entry as well

[Tim Deegan <tim@xxxxxxx>]

At 12:54 +0100 on 08 Jun (1339160091), George Dunlap wrote:
> Return the p2m level of the entry which filled this request.
> Intended to be used to see if pages returned by the balloon
> driver are part of a superpage, and reclaim them if so.

This looks broadly correct, but it's a bit invasive.  If there's any way
to rework patch 2 not to need it that would be helpful.  It looks like
the main use is for detecting and removing superpage PoD entries; maybe
that could be done with a sweep like you have in the non-PoD case?

One niggle: returning level=5 on error is non-obvious, and it doesn't
look like your code in patch 2 uses that.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel