Re: [Xen-devel] [PATCH] libxl: further fixups re LIBXL_DOMAIN_TYPE process

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-06-11 at 17:43 +0100, Ian Jackson wrote:
> Here's another patch which needs to go on top of my async save/restore
> series.
> 
> Ian.
> 
> From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Subject: [PATCH] libxl: further fixups re LIBXL_DOMAIN_TYPE
> 
> * Abolish the macro LIBXL__DOMAIN_IS_TYPE which had incorrect error
>   handlng.  At every call site, replace it with an open-coded call to

   handling

>   libxl_domain_type and check against LIBXL_DOMAIN_TYPE_INVALID.
> 
> * This involves adding an `out:' to libxl_domain_unpause.
> 
> * In libxl_domain_destroy and do_pci_add, do not `default: abort();'
>   if the domain type cannot be found.  Instead switch on
>   LIBXL_DOMAIN_TYPE_INVALID specifically and do some actual error
>   handling.
> 
> * In libxl__primary_console_find, remove a spurious default clause
>   from the domain type switch.
> 
> * In libxl_domain_suspend (as reorganised) error check, check for
>   LIBXL_DOMAIN_TYPE_INVALID and remove a pointless extra log message.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel