Re: [Xen-devel] [PATCH] tools/hotplug: fix locking

[Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On 12.06.2012 08:53, Kouya Shimura wrote:
> Hi,
> 
> The owner support is introduced in c/s 8175, not by me.
> Anyway, something is wrong with your execution trace.
> 
>> + '[' 6 -gt 5 ']'
>> + sleep 1
> <<< Why claim_lock() returns here???
>> + do_or_die losetup -r /dev/loop27 
>> /OVS/Repositories/0004fb00000300000aac184a9bbab7a9/VirtualDisks/0004fb00001200002b0ef651033c8381.img
>> + losetup -r /dev/loop27 
>> /OVS/Repositories/0004fb00000300000aac184a9bbab7a9/Vi
> 
> I don't know what is a problem and whether your patch resolves the issue or 
> not.

I can confirm this problem, I've faced it some time ago:
http://lists.xen.org/archives/html/xen-devel/2011-07/msg00182.html

> It would be better to replace locking.sh with the RHEL5 implementation
> which uses 'flock' rather than to fix it.

I agree. Currently I've workarounded it by adding flock in udev rule which run
this script, but working locking.sh will be much nicer.

-- 
Best Regards / Pozdrawiam,
Marek Marczykowski
Invisible Things Lab

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel