Re: [Xen-devel] [PATCH] tools: adjust --datadir option passed to qemu-upstream's configure script

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.06.12 at 13:41, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
wrote:
> On Mon, 11 Jun 2012, Jan Beulich wrote:
>> > However your patch changes the location of data_dir for the
>> > installed case too, from /usr/share/qemu-xen to /usr/lib/xen/share/qemu.
>> 
>> Sure. But it doesn't matter where exactly the bits get put (and I
>> actually view the pace they're currently at as less consistent then
>> where they would end up with the patch, but admittedly that's
>> likely a matter of taste).
>> 
>> > If you are after the non-installed case, you must be already setting
>> > device_model_override in your VM config file to point to the right
>> > binary. You might as well pass:
>> 
>> No, I did not have to set anything like that - xl/libxl appear to
>> be figuring out quite fine where the binary is. Having to add such
>> or this ...
> 
> xl loads the binary from LIBEXEC/qemu-system-i386, where LIBEXEC is
> usually /usr/lib/xen/bin.  Do you set the LIBEXEC configuration
> differently somewhere?

Not directly - I'm patching Config.mk:buildmakevars2file:

@@ -143,7 +143,7 @@ define buildmakevars2file-closure
                  SBINDIR BINDIR LIBEXEC LIBDIR SHAREDIR PRIVATE_BINDIR     \
                  XENFIRMWAREDIR XEN_CONFIG_DIR XEN_SCRIPT_DIR XEN_LOCK_DIR \
                  XEN_RUN_DIR XEN_PAGING_DIR,                               \
-                 echo "$(var)=\"$($(var))\"" >>$(1).tmp;)        \
+                 echo "$(var)=\"$(DESTDIR)$($(var))\"" >>$(1).tmp;)        \
        $(call move-if-changed,$(1).tmp,$(1))
 endef
 
>> > device_model_args = ['-L', '/path/to/share/file' ]
>> 
>> ... would additionally require the VM config files to be updated
>> each time I update to the tip of -unstable, as I'm having a date
>> tag somewhere in the path.
>> 
>> > that should solve your problem.
>> 
>> It certainly would, but at a price I consider too high.
> 
> I understand what you say, but I fail to see how you can have a working
> out of the box configuration using qemu from the build tree... 

Correct, without above patch (inherited from xend days) this
presumably wouldn't work. But it really should (and should always
have also for xend/xm), but for making it work both in the not-
installed and installed cases, much more than the above patch is
going to be needed afaict.

So in the end I assume I'll have to carry that hunk we're discussing
here alongside the other adjustment...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel