Re: [Xen-devel] [PATCH 18/38] arm: implement vpl011 (UART) emulator.

[Tim Deegan <tim@xxxxxxx>]

At 10:34 +0100 on 07 Jun (1339065291), Ian Campbell wrote:
> On Thu, 2012-06-07 at 10:29 +0100, Tim Deegan wrote:
> > > +int domain_uart0_init(struct domain *d)
> > > +{
> > > +    int rc;
> > > +    if ( d->domain_id == 0 )
> > > +        return 0;
> > 
> > Why?  There's no equivalent gate on the MMIO handlers.
> 
> dom0 has the actual uart mapped at this address, not the emulated one.
> Maybe that should be written at the caller instead?

Yes - ideally in the same place that puts the MMIO hooks in that will
call the other functions in this file. 

Tim.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel